From ad73387c06d7d168dafc0e7af8c601c2c63d967e Mon Sep 17 00:00:00 2001 From: peverwhee Date: Wed, 21 Aug 2024 15:35:18 -0600 Subject: [PATCH 1/8] adding initial PR template --- .../pull_request_template.md | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md new file mode 100644 index 00000000..106fe72a --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -0,0 +1,29 @@ +Tag name (required for main): +Originator(s): + +Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): + +Describe any changes made to build system: + +Describe any changes made to the namelist: + +List any changes to the defaults for the input datasets (e.g. boundary datasets): + +List all files eliminated and why: + +List all files added and what they do: + +List all existing files that have been modified, and describe the changes: +--Helpful git command: `git diff --name-status development...` + + +If there are new failures (compare to the existing-test-failures.txt file), +have them OK'd by the gatekeeper, note them here, and add them to the file. +If there are baseline differences, include the test and the reason for the +diff. What is the nature of the change? Roundoff? + +derecho/intel/aux_sima: + +derecho/gnu/aux_sima: + +CAM-SIMA date used for the baseline comparison tests if different than latest: From 37a8b4ffb4e13e8a1d1f8752cb5e164962ca0a01 Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Wed, 21 Aug 2024 15:45:23 -0600 Subject: [PATCH 2/8] Update pull_request_template.md --- .../PULL_REQUEST_TEMPLATE/pull_request_template.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 106fe72a..d5e55fc9 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,7 +1,10 @@ -Tag name (required for main): -Originator(s): +**Tag name** (required for main): -Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): +**Originator(s)**: + +**Summary** (include the keyword ['closes', 'fixes', 'resolves'] and issue number): + +**Changes** Describe any changes made to build system: @@ -13,9 +16,9 @@ List all files eliminated and why: List all files added and what they do: -List all existing files that have been modified, and describe the changes: ---Helpful git command: `git diff --name-status development...` +List all existing files that have been modified, and describe the changes (Helpful git command: `git diff --name-status development...`): +**Testing** If there are new failures (compare to the existing-test-failures.txt file), have them OK'd by the gatekeeper, note them here, and add them to the file. From cb893d3b0f7ed140bf51e057419a23815e0a618f Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Wed, 21 Aug 2024 15:51:02 -0600 Subject: [PATCH 3/8] Rename pull_request_template.md to dev_pr.md --- .../PULL_REQUEST_TEMPLATE/{pull_request_template.md => dev_pr.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/PULL_REQUEST_TEMPLATE/{pull_request_template.md => dev_pr.md} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/dev_pr.md similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE/pull_request_template.md rename to .github/PULL_REQUEST_TEMPLATE/dev_pr.md From e1653c4381af76adfcd5d5cb16cde4e0eabf7077 Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Wed, 21 Aug 2024 15:52:53 -0600 Subject: [PATCH 4/8] Rename .github/PULL_REQUEST_TEMPLATE/dev_pr.md to .github/pull_request_template.md --- .../{PULL_REQUEST_TEMPLATE/dev_pr.md => pull_request_template.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{PULL_REQUEST_TEMPLATE/dev_pr.md => pull_request_template.md} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE/dev_pr.md b/.github/pull_request_template.md similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE/dev_pr.md rename to .github/pull_request_template.md From 31301dd7de59691194ab73a80e544de4ab382f63 Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Wed, 21 Aug 2024 15:56:21 -0600 Subject: [PATCH 5/8] Update pull_request_template.md --- .github/pull_request_template.md | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d5e55fc9..961834d8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,10 +1,7 @@ -**Tag name** (required for main): +Tag name (required for main): +Originator(s): -**Originator(s)**: - -**Summary** (include the keyword ['closes', 'fixes', 'resolves'] and issue number): - -**Changes** +Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): Describe any changes made to build system: @@ -16,9 +13,8 @@ List all files eliminated and why: List all files added and what they do: -List all existing files that have been modified, and describe the changes (Helpful git command: `git diff --name-status development...`): - -**Testing** +List all existing files that have been modified, and describe the changes: +(Helpful git command: `git diff --name-status development...`) If there are new failures (compare to the existing-test-failures.txt file), have them OK'd by the gatekeeper, note them here, and add them to the file. From 2f7145d2bbf04e00ec9e4275beb8c4feecc623cd Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Tue, 27 Aug 2024 11:39:01 -0600 Subject: [PATCH 6/8] Add section on climate-changing validation --- .github/pull_request_template.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 961834d8..3ded943d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -25,4 +25,7 @@ derecho/intel/aux_sima: derecho/gnu/aux_sima: +If this changes climate describe any run(s) done to evaluate the new +climate in enough detail that it(they) could be reproduced: + CAM-SIMA date used for the baseline comparison tests if different than latest: From e9b4920e09ec40ce942270887a16ad0e4bab3acc Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Fri, 6 Sep 2024 15:49:30 -0600 Subject: [PATCH 7/8] update test failure file path --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3ded943d..8f085bf9 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -16,7 +16,7 @@ List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...`) -If there are new failures (compare to the existing-test-failures.txt file), +If there are new failures (compare to the test/existing-test-failures.txt file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? From 18f6bcb529163419660fc70f71bb48a3aac026f6 Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Mon, 16 Sep 2024 16:01:34 -0600 Subject: [PATCH 8/8] update template --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8f085bf9..11b4afff 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ -Tag name (required for main): +Tag name (required for release branches): Originator(s): Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): @@ -16,7 +16,7 @@ List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...`) -If there are new failures (compare to the test/existing-test-failures.txt file), +If there are new failures (compare to the `test/existing-test-failures.txt` file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff?