PR template #290
Open
PR template #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pr template
peverwhee
requested review from
jimmielin,
jtruesdal,
cacraigucar,
mattldawson,
nusbaume,
boulderdaze and
mwaxmonsky
nusbaume
approved these changes
Sep 10, 2024
.github/pull_request_template.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| Tag name (required for main): | |||
There was a problem hiding this comment.
I would change this to say release branches:
Suggested change
| Tag name (required for main): | |
| Tag name (required for release branches): |
.github/pull_request_template.md
Outdated
| List all existing files that have been modified, and describe the changes: | ||
| (Helpful git command: `git diff --name-status development...<your_branch_name>`) | ||
|
|
||
| If there are new failures (compare to the test/existing-test-failures.txt file), |
There was a problem hiding this comment.
I might vote to have the file listed as "code" here:
Suggested change
| If there are new failures (compare to the test/existing-test-failures.txt file), | |
| If there are new failures (compare to the `test/existing-test-failures.txt` file), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in the new PR template for CAM-SIMA.
See: peverwhee#2 for what it looks like upon opening a PR (though it's not wildly different from the markdown...).