Test musica

[K20shores]

Builds CAM-SIMA with musica. If you look at the output of the cesm log and search of "new state", you'll see the result of print statements we have from the micm component. Again, not much happens as of now with the component, but the connections are there

[nusbaume]

@K20shores I think I know what is going on with the failed test. Would it be alright if pushed the fix to your branch?

[cacraigucar]

My limited 2 cents worth review

[cacraigucar]

Submitting this time with my comment

[cacraigucar]

I see that there is a netCDF file being included with this PR. Typically we have prohibited files from being committed to the code repos and instead, files reside in inputdata. Can the testing files reside in inputdata and be downloaded in the typical cime way?

[K20shores]

@cacraigucar after #222 is merged, into development and then this branch the binary files will be removed. in #222, I added FTP downloads for the netcdf files and I based this branch off of that work

[K20shores]

@nusbaume Now that the other PR is merged, would you like me to copy this dockerfile into the docker folder and leave the dockerfile at the top level directory as one that builds the held suarez scheme?

[nusbaume]

@K20shores that sounds good, unless you want to move both files to under the docker folder (either way is fine with me). Also I assume you'll change the new dockerfile name to something like dockerfile_musica?

[K20shores]

@nusbaume Done. I moved the dockerfiles into the docker folder and updated instructions accordingly

[cacraigucar]

Just an FYI to folks (I'm not sure where the proper place is to document this). During the manage_externals/checkout_externals step, I got the following message:

=> ERROR [ 9/21] RUN ./manage_externals/checkout_externals 0.5s

[ 9/21] RUN ./manage_externals/checkout_externals:
0.483 /usr/bin/env: 'python\r': No such file or directory
0.483 /usr/bin/env: use -[v]S to pass options in shebang lines

@mwaxmonsky helped me and he finally figured out that my TortoiseGit (which I used to do my git clone/checkout on my Windows box) had an option to automatically convert line feeds into Windows line feeds. I believe this is the default setting for TortoiseGit (but my admins installed this years ago, so I'm not completely sure). Turning off the auto convert, allowed me to proceed with the manage_externals/checkout_externals step.

[cacraigucar]

From the usability standpoint, I approve this PR

[nusbaume]

@K20shores I have some changes to config_component.xml that I want to make for this PR, but I figured it would be easier for me to just push them directly to the branch as opposed to making a bunch of change requests. Is that OK with you, or would you rather I just add the requests to a review on Github instead?

[K20shores]

@K20shores I have some changes to config_component.xml that I want to make for this PR, but I figured it would be easier for me to just push them directly to the branch as opposed to making a bunch of change requests. Is that OK with you, or would you rather I just add the requests to a review on Github instead?

yes, please push directly to this branch!

[nusbaume]

I've pushed the changes I wanted, so this PR is good on my end!

I should note that I tested my changes by building/running both the cam-sima and musica containers. Still, it would be good to have others re-build/run the containers themselves at least one more time to make sure I didn't break anything. Thanks!

[peverwhee]

looks good! thanks!

[mwaxmonsky]

Looks good to me! Apologies for the delay!