Modifications to Simulation

[davidhassell]

Work is underway to actually create the CMIP6 simulation documents. This may suggest in minor changes to the properties.

For example, there is a property called further_info_url. I think this was a mistake (mine!) - this is to CMIP6 specific - and this attribute should go in as an extra_attribute (already allowed).

A pull request will follow when any changes are mooted.

[bnlawrence]

I wonder whether the easiest solution would be to put a "CMIP6_simulation" into the activity package (along with a revised simulation, which would hit #35).

[bnlawrence]

(Or create a new CMIP package, and put anything we want in there as sub-classes of the others, for any other CMIP-isms we may find.)

[davidhassell]

I agree with the CMIP6 subclass approach

[davidhassell]

In the here and now, I propose to remove the following from the Simulation class (https://github.com/ES-DOC/esdoc-cim-v2-schema/blob/master/data_classes.py#L96):

            ('realization_index', 'int', '0.1',
                'realization number, e.g. 5'),
            ('initialization_index', 'int', '0.1',
                'Index variant of initialization method, e.g. 1'),
            ('physics_index', 'int', '0.1',
                'index for model physics, e.g. 3'),
            ('forcing_index', 'int', '0.1',
                'index for variant of forcing, e.g. 2'),
            ('further_info_url', 'str', '0.1',
                'On-line location of documentation'),

as these are too CMIP6 specific. Pull Request to follow. For CMIP6, these will be included via 'extra_attributes'

Note that I have left 'variant_info' in.