Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native got error: "Browser history needs a DOM" #11

Open
hzuhyb opened this issue Jun 16, 2018 · 5 comments
Open

React Native got error: "Browser history needs a DOM" #11

hzuhyb opened this issue Jun 16, 2018 · 5 comments

Comments

@hzuhyb
Copy link

hzuhyb commented Jun 16, 2018

when import eosjs-keygen, i got the error: "Browser history needs a DOM"

Environment

Environment:
  OS: macOS High Sierra 10.13.1
  Node: 8.9.1
  Yarn: 0.24.5
  npm: 5.5.1

Packages: (wanted => installed)
  react: 16.3.1 => 16.3.1
  react-native: 0.55.4 => 0.55.4

wx20180616-130458 2x

@jcalfee
Copy link
Contributor

jcalfee commented Jun 20, 2018

I also hear there are some needed crypto functions that will not work with RN.

@hzuhyb
Copy link
Author

hzuhyb commented Jun 21, 2018

@jcalfee This error may be caused by using "createBrowserHistory", use "createMemoryHistory" can fix it.
wx20180621-123818 2x

@jcalfee
Copy link
Contributor

jcalfee commented Jun 21, 2018

The code your pointing to is in browser.js .. I don't have a RN environment setup now, I will get some feedback on this and see what I can do though. I suspect there are going to be many changes for RN.

@jcalfee
Copy link
Contributor

jcalfee commented Jun 21, 2018

The best thing for you may be to fork this repo and make the change yourself (until I have done enough research to start changing things). You'll probably uncover more issues ..

Please also make sure that this is the library you need. This is designed to derive and cache keys but also needs a password manager to store a "root" key. This library does not have secure or password protected storage. It does however figure out permission hierarchies and is configurable enough to only store keys you feel are safe to store.

@hzuhyb
Copy link
Author

hzuhyb commented Jun 22, 2018

Thank you for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants