Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources and Samples in Unsorted items #58

Open
floradanna opened this issue Jun 16, 2022 · 5 comments
Open

Sources and Samples in Unsorted items #58

floradanna opened this issue Jun 16, 2022 · 5 comments

Comments

@floradanna
Copy link

floradanna commented Jun 16, 2022

Problem
DataHub Sources and Samples and SOP created in a Study are

  • shown in Unsorted item folder of the Project
  • not shown in Related items of the Study

Example: https://datahub.dev.elixir-belgium.org/single_pages/2#

Expected behaviour
DataHub Sources and Samples created in a Study

  • should not appear in Unsorted item folder of the Project
  • should be shown in Related items of the Study
@rabuono
Copy link
Member

rabuono commented Jun 21, 2022

image
Source Samples and Sample Collection Samples should have their own branch (red arrows) as Samples have in Assays (purple marking).

@vdkkia
Copy link

vdkkia commented Jul 13, 2022

Different way of showing samples in assay and sample_type pages:

image

image

@floradanna
Copy link
Author

floradanna commented Jul 13, 2022

@rabuono In SEEK, Samples are visualised in 2 ways (see screehosts above):
a) as a list, if you visualise all samples (in a assay or project) coming from different sample types
b) in a searchable table, if you visualise samples from 1 sample type

What do we want to have in DataHub?

@rabuono
Copy link
Member

rabuono commented Jul 13, 2022

If Single page enabled is on in the Admin panel, but Advanced features enabled is not, than option "a". Otherwise it might lead to conflicts on instances in which the advanced features are not turned on and Samples can be coming from multiple Sample Types.

If the Advanced features enabled is also turned on, then clicking on the samples in the tree in the left panel should take one to the Assay design>Samples table.

Does it sound good?

@floradanna
Copy link
Author

That's indeed a good point. The features enabled in Admin panel affects this.
It sounds good to me. Let's see if it is possible to do it.

vdkkia added a commit to seek4science/seek that referenced this issue Jul 13, 2022
@vdkkia vdkkia closed this as completed Jul 13, 2022
@vdkkia vdkkia reopened this Jul 28, 2022
vdkkia added a commit to seek4science/seek that referenced this issue Jul 29, 2022
vdkkia added a commit to seek4science/seek that referenced this issue Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants