Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ontology name not visualised in sample_type #43

Open
floradanna opened this issue May 2, 2022 · 6 comments
Open

Ontology name not visualised in sample_type #43

floradanna opened this issue May 2, 2022 · 6 comments

Comments

@floradanna
Copy link

In sample_type, the ontology name is the same of the attribute name, but it should be the name of the ontology instead, as specified in template.

Screenshot 2022-05-02 at 09 35 21

Screenshot 2022-05-02 at 09 34 36

@floradanna
Copy link
Author

Would it be better to shown the ontology name or description? Name is shorter, Description is more descriptive.

@vdkkia
Copy link

vdkkia commented May 3, 2022

@floradanna ENVO in your example is the name of the source. Do you want it to be shown?

@floradanna
Copy link
Author

We need to agree with Rafael on what to show first:

  • ENVO
  • Environmental Ontology
  • the rootTerm name
  • the rootTermURI
  • the link to the entire ontology
  • ...?

Let's skip this issue for now and keep it open. It is not urgent.

@floradanna
Copy link
Author

sample_controlled_vocabs title should be = the name or description of the ontology.
Example: Attribute name = organism part; sample_controlled_vocabs title = efo or Experimental Factor Ontology.

Ideally, the sample_controlled_vocabs title would be the term associated with the rootTermURI, but not sure if this info get stored somewhere in the instance database.

@floradanna
Copy link
Author

Found new issue for Ontology term "organism". Not all ontology terms are available in the dynamic table. Maybe time out issue?

Possible solution: when installing the instance, all terms need to be loaded and stored (it might takes several hours but only at the beginning).

@floradanna
Copy link
Author

@vdkkia The sample_controlled_vocabs title would be the term associated with the rootTermURI, which it should be stored somewhere in the instance. Could you please do this?

vdkkia added a commit that referenced this issue Jun 3, 2022
@vdkkia vdkkia closed this as completed Jun 3, 2022
@vdkkia vdkkia reopened this Jun 15, 2022
vdkkia added a commit to seek4science/seek that referenced this issue Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants