Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1D CSR Model #627

Merged
merged 153 commits into from
Aug 29, 2024
Merged

1D CSR Model #627

merged 153 commits into from
Aug 29, 2024

Conversation

xbojanic
Copy link
Contributor

@xbojanic xbojanic commented May 31, 2024 •
edited by ax3l
Loading

This PR implements a 1D CSR model. Currently, this is the ultrarelativistic steady-state wakefield model (eg, eq 19 of
E. L. Saldin et al, NIMA 398, p. 373-394 (1997), DOI:10.1016/S0168-9002(97)00822-X).

This includes:

  • wake function calculation
    • integrate out singularity value
  • beam profile convolution
  • apply the force "kick" to the particle momentum.
  • benchmark example
  • GPU support
  • MPI support
  • user-facing documentation & controls: inputs & Python

Close #452

@ax3l ax3l requested review from ax3l and cemitch99 May 31, 2024 22:45
@ax3l ax3l added the component: CSR coherent synchrotron radiation models label May 31, 2024
cemitch99
cemitch99 reviewed May 31, 2024
View reviewed changes
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on posting your first ImpactX pull request! The changes to the examples (your local tests) probably don't need to appear in this request. We can add a new test that includes CSR, once the wakefield kick is fully implemented.

Alex Bojanich and others added 21 commits June 3, 2024 16:57
Revert changes to examples.
c6c10ab
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e56a00b 
for more information, see https://pre-commit.ci
@cemitch99
Delete examples/cfbend/Wakefield_Functions_Bend_copy.py
c7d4453 
Not part of this PR.
@cemitch99
Delete examples/chicane/open_PMD_to_ASCII_copy.py
8babb41 
Not part of this PR.
@cemitch99
Delete examples/fodo/openPMD_to_ASCII.py
8a43b2a 
Not part of this PR.
Created wakefields directory and moved all relevant wake function fil…
bded7e4 
…es into it. Created 2 new files for the wake force momentum kick.
Merge remote-tracking branch 'xbojanic/Charge_Deposit_Step' into Char…
eb40b4c 
…ge_Deposit_Step

Created the directory wakefields for all new wakefield scripts.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
160eb0c 
for more information, see https://pre-commit.ci
@xbojanic
Delete src/particles/ChargeBinning.H
9d2b152
@xbojanic
Delete src/particles/ChargeBinning.cpp
a0c8bfe
@xbojanic
Delete src/particles/WakeConvolution.H
f657990
@xbojanic
Delete src/particles/WakeConvolution.cpp
e3af840
Added new paths to files to compile
fff3ac2
Merge remote-tracking branch 'xbojanic/Charge_Deposit_Step' into Char…
ddb09b8 
…ge_Deposit_Step

Deleted copy files and added paths to new wakefields directory for compiling
Added necessary paths to new wakefields directory for compilation
05e0426
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d6f0d54 
for more information, see https://pre-commit.ci
@xbojanic
Update ImpactX.cpp by deleting lines responsible for plotting
ad66e67
@xbojanic
Update ImpactX.cpp by adding plotting script (commented)
3901b6b
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7d3590c 
for more information, see https://pre-commit.ci
Removed variable hardcoding by reading in all function parameters
2087d0f
Remove variable hardcoding by reading in function parameters
85b9607
@ax3l @cemitch99
Tighter Tolerances
5bec6ce 
Co-authored-by: Chad Mitchell <[email protected]>
@cemitch99
Update analysis_chicane_csr.py
6132e65 
Relax tolerance 2.5 -> 3.5.
@ax3l @cemitch99
Fix Typo: Convolved
b9155b0 
Co-authored-by: Chad Mitchell <[email protected]>
@ax3l ax3l requested a review from cemitch99 August 29, 2024 02:41
cemitch99
cemitch99 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks, Alex!

@cemitch99 cemitch99 merged commit 9049898 into ECP-WarpX:development Aug 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

@cemitch99 cemitch99 cemitch99 approved these changes

Assignees

@cemitch99 cemitch99

Labels
component: CSR coherent synchrotron radiation models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1D CSR Model
3 participants
@xbojanic @cemitch99 @ax3l