Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double rpn_comm.inc/RPN_COMM.inc #5

Open
LaurentChardon opened this issue Mar 12, 2022 · 1 comment
Open

Double rpn_comm.inc/RPN_COMM.inc #5

LaurentChardon opened this issue Mar 12, 2022 · 1 comment
Assignees

Comments

@LaurentChardon
Copy link
Contributor

There are two rpn_comm.inc: RPN_COMM.inc that contains the good stuff, and rpn_comm.inc that includes RPN_COMM.inc.
These two files seem to exist because of an apparent lack of consistency in gem and rpncomm, as they include one or the other case variant. That's not ideal, as it breaks on case insensitive or case preserving filesystems (Darwin for example is only case preserving by default). Would you consider having only one rpn_comm.inc and harmonizing the include directives in gemdyn, modelutils and rpncomm?

@chantal-pic
Copy link
Contributor

Next version of rpncomm will address this, but there are other problems for Darwin within librmn, and when running GEM.
I am leaving this issue opened and I will keep you posted.

@chantal-pic chantal-pic self-assigned this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants