From d1cb060b65e8d500174f045d08bb64a939925857 Mon Sep 17 00:00:00 2001 From: Derek Bruening Date: Wed, 9 Oct 2024 10:34:51 -0400 Subject: [PATCH] Restore msgbox_mask package defaults Replaces the AUTOMATED_TESTING set in package builds by PR #2474 with the new DISABLE_ZLIB CMake option added by DynamoRIO/dynamorio#7030. This fixes a regression where msgbox_mask was set to 0 by default in packages, which caused many users to fail to obtain error information and has led to confusion with silent errors. Fixes DynamoRIO/dynamorio#7025 --- package.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.cmake b/package.cmake index 6ddc5769..0f5b3b52 100644 --- a/package.cmake +++ b/package.cmake @@ -1,5 +1,5 @@ # ********************************************************** -# Copyright (c) 2010-2022 Google, Inc. All rights reserved. +# Copyright (c) 2010-2024 Google, Inc. All rights reserved. # Copyright (c) 2009-2010 VMware, Inc. All rights reserved. # ********************************************************** @@ -136,7 +136,7 @@ set(base_cache " UNIQUE_BUILD_NUMBER:STRING=${arg_ubuild} BUILD_TOOL_TESTS:BOOL=OFF BUILDING_PACKAGE:BOOL=ON - AUTOMATED_TESTING:BOOL=ON + DISABLE_ZLIB:BOOL=ON ${sub_entry} ${arg_cacheappend} ${base_cache}