Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Primitive] Floor: Redo the model for floor #37

Open
sloorush opened this issue Dec 14, 2023 · 0 comments · May be fixed by #41
Open

[Primitive] Floor: Redo the model for floor #37

sloorush opened this issue Dec 14, 2023 · 0 comments · May be fixed by #41
Labels
bug Something isn't working help wanted Extra attention is needed M Medium sized work

Comments

@sloorush
Copy link
Member

sloorush commented Dec 14, 2023 •
edited
Loading

Redo the model function for floor to handle inputs like 1E200.

The current model of floor calculates it by using a very non-intrusive (with the actual primitive being tested) approach by using strings to calculate the result. But it fails to evaluate inputs like 1E200 and fails.
@sloorush sloorush added help wanted Extra attention is needed M Medium sized work labels Dec 14, 2023
@sloorush sloorush changed the title Redo the model for floor [Primitive] Floor: Redo the model for floor Dec 14, 2023
@sloorush sloorush added the bug Something isn't working label Dec 14, 2023
@sloorush sloorush linked a pull request Dec 19, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed M Medium sized work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New floor model Dyalog/ullu
1 participant
@sloorush