Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying form of cholmod_*_xtype #720

Open
rayegun opened this issue Jan 9, 2024 · 1 comment
Open

Copying form of cholmod_*_xtype #720

rayegun opened this issue Jan 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rayegun
Copy link
Contributor

rayegun commented Jan 9, 2024

Currently the semantics of cholmod_*_xtype are not great since it mutates the data type of an object. It would be nicer in most cases to have cholmod_*_copy_xtype which returns a new object with the new data type. This would avoid the double memory allocation of cholmod_*_copy followed by cholmod_*_xtype.

@DrTimothyAldenDavis DrTimothyAldenDavis added the enhancement New feature or request label Jan 9, 2024
@DrTimothyAldenDavis
Copy link
Owner

That would be useful. I'll consider it for CHOLMOD 5.2 (I would bump the 2nd digit from 1 to 2, because this would be a new addition to the user-visible API). I'd like to keep CHOLMOD 5.1.1 as-is for SuiteSparse 7.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants