Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes required #26

Open
trolit opened this issue Feb 11, 2022 · 0 comments
Open

Minor changes required #26

trolit opened this issue Feb 11, 2022 · 0 comments
Assignees
@Dorota1997

Comments

@trolit
Copy link
Collaborator

trolit commented Feb 11, 2022 •
edited
Loading

@Dorota1997 consider following things to add / change in the portfolio and make feature/ for it?

  • some tags should have self-closing (e.g. About.js).
  • apply single convention to spacing (e.g. About.js)
  • add Prettier and ESLint with desired config so future PR's are more convenient to review
  • review all files and use const / let instead of var
  • some inline styles could be moved to scss files like that one.
  • add Idelavois portfolio adaptation in README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dorota1997 Dorota1997

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dorota1997 @trolit