Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider cleaning up signature formatting #121

Closed
madelson opened this issue Aug 7, 2022 · 2 comments
Closed

Consider cleaning up signature formatting #121

madelson opened this issue Aug 7, 2022 · 2 comments

Comments

@madelson
Copy link
Contributor

madelson commented Aug 7, 2022

I feel that the member signatures generated by the tool could be cleaned up a bit (e.g. in this file).

Primarily:

  • It would be nice to use T? syntax rather than System.Nullable<T> for nullable value types
  • It would be nice to have spacing around = for parameter default values
  • It would be nice to use = default instead of = default(T) for value type default values

Thoughts? If you agree, I'd be happy to work on a PR.

@Doraku
Copy link
Owner

Doraku commented Aug 8, 2022

hum the definition of a member use ICSharpCode.Decompiler to be written, I am not sure this is something easily changeable. It should at least be easier to clean the System.Nullable<T> > T? in type links.

@Doraku
Copy link
Owner

Doraku commented Oct 14, 2024

Sorry for the long absence, looking back at this issue since the definition is completely in the hand of the ICsharpCode.Decompiler library, I feel like changing the types from System.Nullable<T> to T? could create confusion if the definition and the parameters do not use the same representation (even more so with the nullable annotation) so I think it will stay as is. I hope you understand 😉

@Doraku Doraku closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants