Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Every tab re-submitted when restoring sessions #35

Open
da2x opened this issue Jul 15, 2018 · 3 comments
Open

Every tab re-submitted when restoring sessions #35

da2x opened this issue Jul 15, 2018 · 3 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@da2x
Copy link
Contributor

da2x commented Jul 15, 2018

  1. Set your browser to restore tabs from last session on startup
  2. Open a few choice web pages in different tabs
  3. Restart the browser
  4. Wait 8 seconds

Expected: Only newly opened tabs should be sent to Timeline.

Actual: Every tab from the previous session is resubmitted at the same time.

@DominicMaas
Copy link
Owner

How would we go about implementing this?

@da2x
Copy link
Contributor Author

da2x commented Jul 15, 2018

Block submissions for non-active tabs for the first 30 seconds after startup except for active/focused tabs. The tab object is available as the sendMessage sender so you can check which tab is active there without requeing tabs permission or complexity. Just add a boolen in background.ja called allowBackgroundTabSubmissions set to false, and flip it to true after a timeout.

Would normally submit background tabs, but just inoring these at startup should fix this issue. If the first thing you do is open a page and open ten background tabs, you might loose some submissions. Could also look at the tab creation time; I believe that is also available in the tab object.

@Jakosaur
Copy link

Was about to make an issue about this for pinned tabs as well as what you mentioned when Chrome restores the tabs you had open last.

@DominicMaas DominicMaas added enhancement New feature or request bug Something isn't working labels Jul 17, 2018
@DominicMaas DominicMaas added this to the 1.0.5 milestone Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants