I think github-runner is ill

[davidnewcomb]

Why does the github-runner keep removing the version number ENV TOR_VERSION_X64="..." in the Dockerfile?

I've updated it once already. I've come to add the latest browser version for X64 and it's gone again!

Here is the commit made by the runner: ac8dba2

I'm pretty sure that #56 is the message you get when the version is empty.

[lawndoc]

I have a busy week this week and am not at home. I can take a look at this next week. If someone wanted to help investigate sooner, you can check out this repo and run the commands in the workflow file responsible for this to troubleshoot what is breaking it.

[davidnewcomb]

Haha - typo! Checked in a fix.

I wanted it to be able to run when $current was empty so I had to add some quotes to stop dpkg complaining.
I also changed the gt to eq because 13.0.13 is not gt than "". Really we don't care if the number is greater, we should only care about what they say the latest version is. If they have to pull a version for whatever reason we wouldn't update.

It's on a nightly schedule so if it updates tonight then hurray :)

[davidnewcomb]

It didn't pass completely. It blew up further down the line when it tried to apply an empty tag (because $current is empty). I have updated the Dockerfile with the latest version 13.0.13 so current won't be empty.

It is now failing during the Verify GPG signature of the Tor Browser binary part of the build.

When I run this locally, it sometimes fails here for me. I usually just comment out those lines and run it without the check but I don't think I can do this "for real". I've run the block that is failing and it works when I do it on the command line but not always when I run it via docker build. I have looked into this problem before but never found a solution.

Perhaps there should be less shell script in the Dockerfile and more scripts run on the docker side so one can add more debug etc. Just a thought.

Anyway, I think the version stuff is fixed and the build problems were always there so I think I'm done; although I would like to get to the bottom of why it fails sometimes.