Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEVELOP pdf space lost with images on sponge PDF template #31456

Open
wants to merge 57 commits into
base: develop
Choose a base branch
from

Conversation

thersane-john
Copy link
Contributor

@thersane-john thersane-john commented Oct 18, 2024

Instructions

NEED PR #31442 to be merged before Or merge this one to merge both

thersane-john and others added 30 commits October 4, 2024 15:29
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
@thersane-john thersane-john changed the base branch from 20.0 to develop October 24, 2024 09:16
@thersane-john thersane-john changed the title Fix v20 pdf space lost with images on sponge PDF template Fix DEVELOP pdf space lost with images on sponge PDF template Oct 24, 2024
@thersane-john

This comment was marked as outdated.

…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
@thersane-john thersane-john marked this pull request as draft October 24, 2024 10:07
@thersane-john thersane-john marked this pull request as ready for review October 24, 2024 10:09
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
@thersane-john
Copy link
Contributor Author

thersane-john commented Oct 25, 2024

@eldy Le fix est en production (version V20) chez nous depuis 3 semaines pour les devis et une semaine pour les commandes et les factures, j'ai fait quelques fix et là je ne trouve plus d'anomalie.

Une fois mergé, je pourrais par contre faire une petite évolution car j'ai trouvé le moyen de fixer aussi les sauts de page liés aux extrafields sur colonnes qui sont plus long que la description.
Avec cette evolution les PDF n'auront normalement plus aucuns problèmes de saut de page, en tout cas pour le tableau des produits.


@eldy The fix has been in production (version V20) with us for 3 weeks for quotes and one week for orders and invoices, I've made a few fixes and now I can't find any anomalies.

Once merged, however, I'll be able to make a small change, as I've found a way to fix the page breaks linked to column extrafields that are longer than the description.
With this evolution, PDFs will normally no longer have any page break problems, at least for the product table.

@thersane-john
Copy link
Contributor Author

@eldy can you check please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants