Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: tables for a new module, supplier contract (same a contrat but for supplier) #31346

Conversation

kkhelifa-opendsi
Copy link
Contributor

Tables for a new module, supplier contract (same a contrat but for supplier)

I renamed the fields in french to english and remove obsolete fields
I plan to used template for the product line for customer contract et supplier contract same as template for proposal, orders, invoices but specific for contract.

Is it ok ?

@eldy
Copy link
Member

eldy commented Oct 13, 2024

Currently, the module contract was designed to work on both side for customer and supplier.
Can we support this with just a flag 'Customer / Supplier' on existing contract ?

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Oct 13, 2024
@kkhelifa-opendsi
Copy link
Contributor Author

ok

@kkhelifa-opendsi
Copy link
Contributor Author

In Dolibarr, modules are now split between customer and supplier.
This makes it possible to have different sets of document templates, separate additional fields, separate reference, add lines specific to purchases and sales, etc...
Now this can be done in a single module, but not in the same way as other modules where the customer and supplier parts have been separated.

@philippe-opendsi
Copy link
Contributor

we need to start developing. @eldy Are you sure we're starting with a single module ?

@eldy
Copy link
Member

eldy commented Oct 19, 2024

we need to start developing. @eldy Are you sure we're starting with a single module ?

No, not sure. There is pro and cons.

So i I procrastinated by notice you the fact that we can already do it in a simple manner. I would just like to be sure that before starting a full module you were aware that we can already manage supplier contract in a simple way. And if this is enough for short time, may be priority for this enhancement is no more a priority and we can merge other PR before...

@pscoffoni-opendsi
Copy link

@eldy Concerning our customer's request, the module as it stands doesn't meet his requirements. He already uses the module for the customer part, and would like to be able to clearly differentiate between the two types of contract with additional fields specific to customers and suppliers. The same applies to document templates.
Last but not least, the lines need to retrieve purchase prices for products/services, rather than sales prices as at present.
That's why we're moving towards a complete, separate module.
If you think this is premature, we can do it as an external module and push it later into the core.

@pscoffoni-opendsi
Copy link

This will be an external module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants