Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter by customer sellers #31049

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add filter by customer sellers #31049

wants to merge 5 commits into from

Conversation

defrance
Copy link
Contributor

No description provided.

@eldy eldy added the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label Sep 23, 2024
@defrance
Copy link
Contributor Author

defrance commented Oct 3, 2024

OK so how understand debug some error message :
There was 1 failure:

  1. CodingPhpTest::testPHP with data set New webservice method to create a thirdparty with contact and user #549 (array('cabyprodserv.php', '/home//build/Dolibarr/d.../stats', 'stats', 'compta/stats/cabyprodserv.php', '/home//build/Dolibarr/d...rv.php', '', '', 'file'))
    Found non quoted or not casted var in sql request compta/stats/cabyprodserv.php - Bad.
    Failed asserting that false is true.
    /home/******/build/Dolibarr/dolibarr/test/phpunit/CodingPhpTest.php:304
    FAILURES!
    Tests: 788, Assertions: 56658, Failures: 1.

@frederic34
Copy link
Member

@defrance can you update your PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederic34 frederic34 frederic34 left review comments

@eldy eldy eldy left review comments

Assignees
No one assigned
Labels
PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@defrance @frederic34 @eldy