Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Error message overwrited when a error occurs during update of product multilangs #30841

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

kkhelifa-opendsi
Copy link
Contributor

FIX: Error message overwrited when a error occurs during update of product multilangs

@kkhelifa-opendsi kkhelifa-opendsi changed the base branch from develop to 18.0 September 3, 2024 15:10
kkhelifa-opendsi added a commit to Easya-Solutions/dolibarr that referenced this pull request Sep 3, 2024
@eldy eldy added the Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them. label Sep 4, 2024
Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me, this error is not due to local sql error but setMultiLangs call and errors are localy handled into setMultiLangs

@rycks
Copy link
Contributor

rycks commented Sep 5, 2024

@eldy ok for us, do we have to change tag or add a new one ?

@eldy
Copy link
Member

eldy commented Sep 5, 2024

@eldy ok for us, do we have to change tag or add a new one ?

No, just set the approved status so i know i can check on my side.

@eldy eldy merged commit 21ec7ce into Dolibarr:18.0 Sep 6, 2024
1 check passed
lvessiller-opendsi added a commit to Easya-Solutions/dolibarr that referenced this pull request Sep 13, 2024
…uct_multilangs

CORE product: Fix error message overwrited when a error occurs during update of product multilangs PR Dolibarr#30841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants