(really) Fix #20527 Accountancy Unbalanced entry proposed when an employee are declared on social contribution

[t3cneo]

FIX #20527

Merged PR #21193 doesn't fix the issue at least in latest v19.0.2

[eldy]

It seems another fix was applied with this patch ca39809 in v18 (and merged into upstream).
Can you describe how to reproduce the bug if you still have it in develop despit this patch ?

[t3cneo]

I'm experiencing the issue described in #20527 in v 19.0.2 : A social charge attached to a user will result in unbalanced entry.

To my (very little and possibly wrong) understanding, merged PR #21193 was "flawed" : the patch adds a test to detect a social charge and intend to skip user related journal entry but it doesn't because !$is_sc is used instead of $is_sc

I guess that is why someone was surprised the issue was closed back then.

This has been kept since and even more tests have been added from line 339 to line 356 making the condition in line 361 impossible to meet.

[eldy]

When line is a user line, when for social contribution, expense report or salary payment, the line is supported by the rest of code, thus must din't need to ignore line type user. Management is not implemented for other type this is why there is a continue for any other cases.
Also after fixes merged, it was no more possible to reproduce the bug (meaning bug was fixed).
If there is still a use case known to reproduce the bug, this use case must be described. Currently, with all merged last fix, i did not succeed in reproducing the bug.

[t3cneo]

When line is a user line, when for social contribution, expense report or salary payment

This is not what I understand from line 361

if ($links[$key]['type'] == 'user' && !$is_sc && !$is_salary && !$is_expensereport) {

I understand when line is a user line AND when NOT for social contribution AND NOT expense report AND NOT salary payment which is basically never...

Please correct me if I'm wrong, I'm just a user not a dev.

Anyway, when I create a social charge and attach it to a user :

Here is what I get in accountancy :

This PR fixes this.

It removes expense report and salary payment as they are correctly handled.

EDIT :

Oh sorry I just tried with latest patch from develop and it is indeed fixed by ca39809
I therefore think line 361 to line 365 can be removed as it is useless.

[eldy]

i will keep line 361 to 365 for few version waiting to be sure everything is correct and stable before trying to remove it to avoid to increase risk of regression...
Thanks for you feedback on the very latest version so i can close the ticket.