-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix line_order when we have children with children #30423
Open
MaximilienR-easya
wants to merge
7
commits into
Dolibarr:develop
Choose a base branch
from
MaximilienR-easya:dev_Fix_children_with_children_line_order
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix line_order when we have children with children #30423
MaximilienR-easya
wants to merge
7
commits into
Dolibarr:develop
from
MaximilienR-easya:dev_Fix_children_with_children_line_order
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2024
What was the trouble ? Can you provide an example ? |
@eldy do you need more exemple ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug or PR need more information
This bug or PR needs more information (answer to a question or more accurate description)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Fix case when we have children with children that are not taken into account and cause a problem with the rank of the lines