Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line_order when we have children with children #30423

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

MaximilienR-easya
Copy link
Contributor

Fix

Fix case when we have children with children that are not taken into account and cause a problem with the rank of the lines

@eldy
Copy link
Member

eldy commented Jul 20, 2024

What was the trouble ? Can you provide an example ?

@eldy eldy added the Bug or PR need more information This bug or PR needs more information (answer to a question or more accurate description) label Jul 20, 2024
@MaximilienR-easya
Copy link
Contributor Author

In a case that we have a product (Test0) who have a child (Test00) who also have child (test01, test02, test03, test04).
Screenshot from 2024-07-22 10-34-19

Without the Fix we obtain that
Screenshot from 2024-07-22 10-33-44
But if we check children recursively, we obtain that

Screenshot from 2024-07-22 10-35-45

If we don't check the children recursively, we can have case like this one where everything is mixed up and not ordered

@MaximilienR-easya
Copy link
Contributor Author

@eldy do you need more exemple ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug or PR need more information This bug or PR needs more information (answer to a question or more accurate description)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants