From efd263579fba5bc2c5e17dfe0d67283808d28362 Mon Sep 17 00:00:00 2001
From: Florent Poinsaut <florent@poinsaut.fr>
Date: Thu, 11 Jul 2024 18:49:44 +0200
Subject: [PATCH] Add a warning if we add a contact that has a user #10789

---
 htdocs/core/tpl/contacts.tpl.php | 31 +++++++++++++++++++++++--------
 htdocs/langs/en_US/main.lang     |  1 +
 2 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/htdocs/core/tpl/contacts.tpl.php b/htdocs/core/tpl/contacts.tpl.php
index 32c6b6a9b5871..cb52f20f94bd8 100644
--- a/htdocs/core/tpl/contacts.tpl.php
+++ b/htdocs/core/tpl/contacts.tpl.php
@@ -255,11 +255,13 @@
 			$entry->contact_id   = $userstatic->id;
 			$entry->contact_html = $userstatic->getNomUrl(-1, '', 0, 0, 0, 0, '', 'valignmiddle');
 			$entry->contact_name = strtolower($userstatic->getFullName($langs));
+			$entry->contact_warning = false;
 		} elseif ($contact['source'] == 'external') {
 			$contactstatic->fetch($contact['id']);
 			$entry->contact_id   = $contactstatic->id;
 			$entry->contact_html = $contactstatic->getNomUrl(1, '', 0, '', 0, 0);
 			$entry->contact_name = strtolower($contactstatic->getFullName($langs));
+			$entry->contact_warning = ($contactstatic->user_id > 0);
 		}
 
 		if ($contact['source'] == 'internal') {
@@ -325,14 +327,27 @@
 print "</tr>";
 
 foreach ($list as $entry) {
-	print '<tr class="oddeven" data-rowid="' . $entry->id . '">';
-
-	print '<td class="tdoverflowmax200" data-thirdparty_id="' . ((int) $entry->thirdparty_id) . '" data-thirdparty_name="' . dol_escape_htmltag($entry->thirdparty_name) . '">'.$entry->thirdparty_html.'</td>';
-	print '<td class="tdoverflowmax200" data-contact_id="' . ((int) $entry->contact_id) . '">'.$entry->contact_html.'</td>';
-	print '<td class="nowrap" data-nature="' . dol_escape_htmltag($entry->nature) . '"><span class="opacitymedium">'.dol_escape_htmltag($entry->nature_html).'</span></td>';
-	print '<td class="tdoverflowmax200" data-type_id="' . ((int) $entry->type_id) . '" data-type="' . dol_escape_htmltag($entry->type) . '">'.dol_escape_htmltag($entry->type).'</td>';
-	print '<td class="tdoverflowmax200 center" data-status_id="' . ((int) $entry->status) . '">'.$entry->status_html.'</td>';
-
+?>
+	<tr class="oddeven" data-rowid="<?= $entry->id ?>">
+		<td class="tdoverflowmax200" data-thirdparty_id="<?= ((int) $entry->thirdparty_id) ?>" data-thirdparty_name="<?= dol_escape_htmltag($entry->thirdparty_name) ?>">
+			<?= $entry->thirdparty_html ?>
+		</td>
+		<td class="tdoverflowmax200" data-contact_id="<?=  ((int) $entry->contact_id) ?>">
+			<?= $entry->contact_html ?>
+		</td>
+		<td class="nowrap" data-nature="<?= dol_escape_htmltag($entry->nature) ?>">
+			<span class="opacitymedium">
+				<?= dol_escape_htmltag($entry->nature_html) ?>
+				</span>
+				<?= ($entry->contact_warning ? img_picto($langs->trans("ThisContactHasAnUser"), 'warning') : '') ?>
+		</td>
+		<td class="tdoverflowmax200" data-type_id="<?= ((int) $entry->type_id) ?>" data-type="<?=  dol_escape_htmltag($entry->type) ?>">
+			<?= dol_escape_htmltag($entry->type) ?>
+		</td>
+		<td class="tdoverflowmax200 center" data-status_id="<?= ((int) $entry->status) ?>">
+			<?= $entry->status_html ?>
+		</td>
+<?php
 	if ($permission) {
 		$href = $_SERVER["PHP_SELF"];
 		$href .= '?id='.((int) $object->id);
diff --git a/htdocs/langs/en_US/main.lang b/htdocs/langs/en_US/main.lang
index 18dc30a2c5f29..3813ea70f76e5 100644
--- a/htdocs/langs/en_US/main.lang
+++ b/htdocs/langs/en_US/main.lang
@@ -1299,3 +1299,4 @@ AllEntities=All entities
 TranslationOfKey=Translation of the key AnyTranslationKey
 SignedStatus=Signed status
 NbRecordQualified=Number of qualified records
+ThisContactHasAnUser=Warning, you must assign the associated user and not this contact to allow access to this object.