Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for GeoIP #54

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Remove support for GeoIP #54

merged 3 commits into from
Nov 13, 2024

Conversation

Schnouki
Copy link
Collaborator

This is a breaking, non-compatible change.

@Schnouki
Remove support for GeoIP
59ff527 
This is a breaking, non-compatible change.
@Schnouki Schnouki self-assigned this Nov 13, 2024
@Schnouki Schnouki mentioned this pull request Nov 13, 2024
Merged
goncalossilva
goncalossilva approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@goncalossilva goncalossilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal is clean, the feature itself felt slightly like bloat, and I assume we don't need it ourselves, so I'm approving this. Let's make sure to release it as 3.0.0 considering it's a breaking change. 😊

@Schnouki Schnouki merged commit c4becbb into main Nov 13, 2024
2 checks passed
@Schnouki Schnouki deleted the thomas/rm-geoip2 branch November 13, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goncalossilva goncalossilva goncalossilva approved these changes

Assignees

@Schnouki Schnouki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schnouki @goncalossilva