Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IOHandler code #1306

Conversation

soumya-codes
Copy link
Contributor

@soumya-codes soumya-codes commented Nov 20, 2024

The IOHandler code is refactored for the following:

  1. Better readability
  2. More Robust error handling
  3. CPU and Memory optimisations

Signed-off-by: soumya-codes <[email protected]>
@soumya-codes soumya-codes marked this pull request as ready for review November 20, 2024 02:06
@soumya-codes
Copy link
Contributor Author

The PR is ready for review.
I may open a separate PR for benchmarking or add benchmarking to this PR itself.

Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this refactor @soumya-codes, the code looks much better now with the improved error handling!

@JyotinderSingh JyotinderSingh merged commit 43debd4 into DiceDB:master Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants