From ed1cfcd706fd3467445788e7811c7dea61e21583 Mon Sep 17 00:00:00 2001 From: Miguel Muscat Date: Sat, 24 Jun 2017 13:22:19 +0200 Subject: [PATCH 1/3] Removed `FactoryInterface` and func test (#3) --- src/FactoryInterface.php | 26 --------------- test/functional/FactoryInterface.php | 47 ---------------------------- 2 files changed, 73 deletions(-) delete mode 100644 src/FactoryInterface.php delete mode 100644 test/functional/FactoryInterface.php diff --git a/src/FactoryInterface.php b/src/FactoryInterface.php deleted file mode 100644 index 2c3a73c..0000000 --- a/src/FactoryInterface.php +++ /dev/null @@ -1,26 +0,0 @@ -mock(static::TEST_SUBJECT_CLASSNAME) - ->make() - ->new(); - - return $mock; - } - - /** - * Tests whether a valid instance of the test subject can be created. - * - * @since 0.1 - */ - public function testCanBeCreated() - { - $subject = $this->createInstance(); - - $this->assertInstanceOf(static::TEST_SUBJECT_CLASSNAME, $subject); - } -} From 5f9f1fe0591a7a8f40b1a172c331ec8d8daf3d3c Mon Sep 17 00:00:00 2001 From: Miguel Muscat Date: Sat, 24 Jun 2017 13:22:34 +0200 Subject: [PATCH 2/3] Added suggestion for `dhii/factory-interface` --- composer.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/composer.json b/composer.json index f0b926c..054b732 100644 --- a/composer.json +++ b/composer.json @@ -25,5 +25,8 @@ "psr-4": { "Dhii\\Di\\": "src/" } + }, + "suggest": { + "dhii/factory-interface": "To create new service instances." } } From 8fa7198387b1e107a122f36bba243a47a79e74b4 Mon Sep 17 00:00:00 2001 From: Anton Ukhanev Date: Tue, 27 Jun 2017 09:33:45 +0200 Subject: [PATCH 3/3] Removed mentions of factory from readme --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index 3f36b79..b79aa74 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,6 @@ In addition to existing [container-interop][] and - [`CompositeContainerInterface`][] - enables [lookup delegation][]. - [`WritableCompositeContainerInterface`][] - a composite container that can have containers added. - [`WritableContainerInterface`][] - a container that can have service definitions added. -- [`FactoryInterface`][] - enables standard [factory][] implementation. - [`ExceptionInterface`][] - any DI exception. The packages adheres to the [SemVer][] specification, and there will be full backward compatibility between minor versions. @@ -21,9 +20,7 @@ Additionally, it follows the rule of the [caret operator][], i.e. there will be [`CompositeContainerInterface`]: https://github.com/Dhii/di-interface/blob/master/src/CompositeContainerInterface.php [`WritableCompositeContainerInterface`]: https://github.com/Dhii/di-interface/blob/master/src/WritableCompositeContainerInterface.php [`WritableContainerInterface`]: https://github.com/Dhii/di-interface/blob/master/src/WritableContainerInterface.php -[`FactoryInterface`]: https://github.com/Dhii/di-interface/blob/master/src/FactoryInterface.php [`ExceptionInterface`]: https://github.com/Dhii/di-interface/blob/master/src/ExceptionInterface.php [lookup delegation]: https://github.com/container-interop/container-interop/blob/master/docs/Delegate-lookup.md -[factory]: https://github.com/container-interop/container-interop/issues/44 [SemVer]: http://semver.org/ [caret operator]: https://getcomposer.org/doc/articles/versions.md#caret