Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure oauth popup windows get closed #53

Open
durka opened this issue Oct 25, 2016 · 2 comments
Open

Make sure oauth popup windows get closed #53

durka opened this issue Oct 25, 2016 · 2 comments

Comments

@durka
Copy link
Contributor

durka commented Oct 25, 2016

Samuel Cole reported on Slack that Safari was reloading the popup in a background tab but keeping it in the background, making it seem like nothing was happening. The popup should close as soon as it finishes redirecting, AFAIK. But maybe there's a way to give it a unique name or something, just in case, so it doesn't go back to a previous tab.

@durka durka changed the title Make sure oauth popups windows get closed Make sure oauth popup windows get closed Oct 25, 2016
@dglazkov
Copy link
Contributor

dglazkov commented Nov 2, 2016

I think this should work now -- we changed the flow altogether.

@durka
Copy link
Contributor Author

durka commented Nov 2, 2016

@samuelcole can you still repro?

@durka durka added question and removed bug labels Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants