-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Length of input text doesn't match what's shown in the samples #49
Comments
This is because the caption as you enter it is limited to 140 characters, taking into account the automatically added suffix " (share yours at myvotematters.today)". One way to fix this would be to shorten that suffix (rephrase and/or buy a shorter domain name). |
Another option would be to relax the limit, but disable sharing to Twitter if your caption is too long. |
Hi, I'm new here but I'm eager to help. Sharing to twitter seems important, but so does having a message. In order to keep both:
If the text box is required, I wouldn't disallow twitter posting, I'd rather enforce the character limit
I can try to code the second option this weekend. |
Yeah, there is technically no limit to the text length as far as rendering it on the image is concerned, though it will get too small to read pretty fast. (The line spacing calculation could use some work too.) I like the option of putting all the text in the image but abbreviating the twitter message (just put in an ellipsis I guess). Also, #58 will add some more breathing room. |
OR we could truncate the comments that people do have on twitter at the character limit and elipisseis and then append a link to our site if ppl want to see the matching FULL text and image. |
assuming the placards actually exist on our site and they have RESTful URIs... |
Yeah that's what I was thinking, and then you render the entire caption on the image.
Haha, this is actually a frontend-only site. The images don't exist anywhere outside of the canvas on the page. |
Yeah I figured the limited scope out after I wrote my comment and realized I was being way too ambitious haha. |
Typing the text that's shown in a sample shows that the actual limit is much shorter.
The text was updated successfully, but these errors were encountered: