Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only keep relevant files for npm module/package #195

Open
1 of 3 tasks
NatsuDzn opened this issue Nov 2, 2022 · 1 comment · Fixed by #246
Open
1 of 3 tasks

Only keep relevant files for npm module/package #195

NatsuDzn opened this issue Nov 2, 2022 · 1 comment · Fixed by #246
Assignees
@Tanguylo
Labels
priority: low type: enhancement New feature or request
Milestone
0.13.0

Comments

@NatsuDzn
Copy link
Contributor

NatsuDzn commented Nov 2, 2022

  • I'm submitting a ...

    • bug report
    • feature request
    • support request => Please do not submit support request here, see note at the top of this template.

  • What is the current behavior?

Some files are still present in the npm modules, however we don't need them
That makes the package larger for no real reason

  • What is the expected behavior?

NPM modules should only have needed files

  • What is the motivation / use case for changing the behavior?

Free more space

  • Possible fixes

Add irrelevant files to https://github.com/Dessia-tech/plot_data/blob/master/.npmignore
@NatsuDzn NatsuDzn added type: enhancement New feature or request priority: low labels Nov 2, 2022
@NatsuDzn NatsuDzn changed the title Only keep relevant files for npm modules Only keep relevant files for npm module/package Nov 2, 2022
@Tanguylo Tanguylo self-assigned this Mar 29, 2023
@Tanguylo Tanguylo added this to the 0.13.0 milestone Mar 29, 2023
@Tanguylo Tanguylo linked a pull request Mar 30, 2023 that will close this issue
chore(clear_modules): fill npmignore #246
Merged
@NatsuDzn
Copy link
Contributor Author

I'm reopening this issue, because there is still some leftover in the package.
.nyc_output and coverage folder

@NatsuDzn NatsuDzn reopened this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tanguylo Tanguylo

Labels
priority: low type: enhancement New feature or request
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

chore(clear_modules): fill npmignore Dessia-tech/plot_data
2 participants
@NatsuDzn @Tanguylo