Clean person names #2471
Open
Clean person names #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
reviewed
Nov 12, 2024
ynr/apps/people/management/commands/people_clean_person_names.py
Outdated
Show resolved
Hide resolved
ynr/apps/people/management/commands/people_clean_person_names.py
Outdated
Show resolved
Hide resolved
ynr/apps/people/management/commands/people_clean_person_names.py
Outdated
Show resolved
Hide resolved
ynr/apps/people/management/commands/people_clean_person_names.py
Outdated
Show resolved
Hide resolved
symroe
force-pushed
the
clean-person-names
branch
from
3e2c7f4
to
7514148
Compare
|
@chris48s I think I've addressed all of these. I've enumerated the whitespace values manually rather than doing something like your suggestion...there weren't many values and this allows us to add in other values in the future if we like. |
chris48s
reviewed
Nov 27, 2024
ynr/apps/people/management/commands/people_clean_person_names.py
Outdated
Show resolved
Hide resolved
ynr/apps/people/management/commands/people_clean_person_names.py
Outdated
Show resolved
Hide resolved
|
I've renamed the function to |
chris48s
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone in our Slack pointed out we have some unicode in names that we don't want. This command sorts that out.