Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 660 create an example to run damages and losses without input files #661

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

feat: 660 create an example to run damages and losses without input files #661

wants to merge 16 commits into from

Conversation

ArdtK
Copy link
Contributor

@ArdtK ArdtK commented Dec 13, 2024 •
edited
Loading

Issue addressed

Solves #660

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

  • Remove check in input files in init of Losses
  • Move creation of analysis_collectiont to Ra2ceHandler.configure so the analyses can be manipulated between the init and the execute.
  • Refactor readers (shouldn't be dataclasses - wrongly changed in feat: 595 adaptation run and combine losses and damages #616)
  • Add an example notebook to prove running Damages and Losses without input files is possible.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

ArdtK and others added 11 commits December 12, 2024 12:51
@ArdtK
chore: rename subpackage and classes; add typehints
b0aa4ae
@ArdtK
chore: refactor subclasses to dataclasses; introduce reader
596dcf2
@ArdtK
chore: add license and docstring
bb78215
@ArdtK
chore: improve check on loaded damage functions
8a3a0b1
@ArdtK
Merge branch 'master' into feat/654-experiment-with-damages-and-losse…
3322aa0 
…s-without-input-files
@ArdtK
tests: add unittest
6908be5
@ArdtK
Merge branch 'feat/654-experiment-with-damages-and-losses-without-inp…
75bc43a 
…ut-files' of https://github.com/Deltares/ra2ce into feat/654-experiment-with-damages-and-losses-without-input-files
@ArdtK
chore: refactor reader
3c64e77
@ArdtK
chore: fix issues with readers (shouldn't be dataclasses)
c46b400
@ArdtK
chore: move creation of analysis collection to configure of handler
edb29b0
@ArdtK
chore: add notebook for running analyses without input files
70dcc2c
@ArdtK ArdtK linked an issue Dec 13, 2024 that may be closed by this pull request
Create an example to run damages and losses without input files #660
Open
@ArdtK ArdtK changed the base branch from master to feat/654-experiment-with-damages-and-losses-without-input-files December 13, 2024 10:01
ArdtK and others added 3 commits December 13, 2024 11:30
@ArdtK
test: fix failing test
7fddd1b
@ArdtK
chore: process review comments
477efd2
@ArdtK
Merge branch 'feat/654-experiment-with-damages-and-losses-without-inp…
06fc7cf 
…ut-files' into feat/660-create-an-example-to-run-damages-and-losses-without-input-files
Base automatically changed from feat/654-experiment-with-damages-and-losses-without-input-files to master December 13, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an example to run damages and losses without input files
1 participant
@ArdtK