Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor existing analyses #658

Open
Carsopre opened this issue Dec 12, 2024 · 0 comments
Open

Refactor existing analyses #658

Carsopre opened this issue Dec 12, 2024 · 0 comments
Labels
enhancement New feature or request triage required Issues without priority assessment or milestone.

Comments

@Carsopre
Copy link
Collaborator

Carsopre commented Dec 12, 2024

Kind of request

Changing existing functionality

Enhancement Description

Update all different Damages and Losses analyses so that they implement the corresponding interfaces and base classes as seen in the proposed diagram of #602.

In addition, categorize those analyses such as OriginClosestDestination which could be consider as PartialAnalyses, these sort of analyses cannot stand on their own and depend on the call from an implementation of the AnalysisBase. In addition their output does not need to be an AnalysisResultWrapper.

Use case

Make a distinction between BaseAnalysei and OrchestratorAnalysis.
An OrchestratorAnalysis will use one or many different BaseAnalysis throughout its lifecycle, combining for instance Damages and Losses. A BaseAnalysis can only use its own definitions or parent classes.

Additional Context

Image

@Carsopre Carsopre added enhancement New feature or request triage required Issues without priority assessment or milestone. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage required Issues without priority assessment or milestone.
Projects
None yet
Development

No branches or pull requests

1 participant