Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segment_graph should be moved out of the NetworkWrapperProtocol #551

Open
sahand-asgarpour opened this issue Aug 13, 2024 · 0 comments
Open

segment_graph should be moved out of the NetworkWrapperProtocol #551

sahand-asgarpour opened this issue Aug 13, 2024 · 0 comments
Labels
architecture refactoring Architectural changes to be addressed by the GAP team

Comments

@sahand-asgarpour
Copy link
Contributor

Kind of request

Changing existing functionality

Enhancement Description

NetworkWrapperProtocol you added method segment_graph. It is not correct to add implemented methods to a protocol. A protocol is meant to only contain signatures (definitions).
If you would like to have such a method that is used in all implementing classes, you should create a base class next to the protocol.

Use case

No response

Additional Context

No response
@sahand-asgarpour sahand-asgarpour added the architecture refactoring Architectural changes to be addressed by the GAP team label Aug 13, 2024
@sahand-asgarpour sahand-asgarpour added this to the Sprint 2024 Q2.4 milestone Aug 13, 2024
@ArdtK ArdtK removed this from the Sprint 2024 Q2.4 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture refactoring Architectural changes to be addressed by the GAP team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArdtK @sahand-asgarpour