Rescale plot when line is toggled #999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkramer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redraws the extend when a line is toggled. Currently uses custom add and remove chart functions. Could be added to chart library instead. Resetting extend in case of shared zoom can lead to unexpected behaviour, don't know exactly what would be expected in those cases.
Test example (durban):
http://localhost:5173/topology/node/viewer_coastal_waves/viewer_coastal_waves_ww3/map/ww3_hs/coordinates/-31.159/31.423
Checklist
rel: new featurerel: improvementrel: fixesrel: ignoreSelect to
rel: ignoreif this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.