Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SageAttention Kernel #147

Open
jason-huang03 opened this issue Nov 24, 2024 · 3 comments
Open

Include SageAttention Kernel #147

jason-huang03 opened this issue Nov 24, 2024 · 3 comments
Assignees

Comments

@jason-huang03
Copy link

Hi thanks for your great work. I am the author of SageAttention. I wonder whether if it is suitable to include SageAttention into the repo. SageAttention is a quantized attention currently optmized for Ada architecture. It supports qk int8 and pv fp8. It will be easy to support qk fp8 too.

@jason-huang03
Copy link
Author

Also I myself have a well optimized W8A8 GEMM kernel that reaches > 500T on 4090. I wonder whether it is suitable to add this into the repo too.

@DefTruth
Copy link
Owner

@jason-huang03
🎉Hi jason-huang03~ thank you very much for your attention to CUDA-Learn-Notes. SageAttention is an excellent work and also a great learning resource. It would be fantastic if it could be integrated into CUDA-Learn-Notes. Please feel free to submit a PR. You can add it to the kernels/sage-attention directory, referring to hgemm as an example. If you can integrate sage-attention into a library, like toy-hgemm library, that would be even better. After the PR is merged, I will pin your work on the README homepage. Thank you very much~

@DefTruth DefTruth assigned DefTruth and jason-huang03 and unassigned DefTruth Nov 24, 2024
@jason-huang03
Copy link
Author

Sounds Great! I will try to figure out how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants