Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed log_dir arg which is None by default #1977

Merged
merged 2 commits into from
May 2, 2024

Conversation

shaydeci
Copy link
Contributor

@shaydeci shaydeci commented May 2, 2024

@shaydeci shaydeci changed the title removed log_dir arg which is None by default (log_dir was replaced with logs_specs https://github.com/pytorch/pytorch/blob/main/torch/distributed/launcher/api.py) removed log_dir arg which is None by default May 2, 2024
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 3548fd5 into master May 2, 2024
6 checks passed
@ofrimasad ofrimasad deleted the bug/SG-000_fix_launch_config_missing_arg branch May 2, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants