Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dynamic Vitamix Image Asset #129

Open
SayadiMohamedOmar opened this issue Mar 13, 2023 · 5 comments
Open

feat: Dynamic Vitamix Image Asset #129

SayadiMohamedOmar opened this issue Mar 13, 2023 · 5 comments
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request

Comments

@SayadiMohamedOmar
Copy link

The purpose of this issue is to give access to the app who is using Vitamix Asset to fetch the assets based on the name of the image so we can use them based on the configuration which will be provided by our app.

Example:
the method provided by vitamin for fetching country by region code.
public static func flag(countryCode: String) -> VitaminAsset?

@SayadiMohamedOmar SayadiMohamedOmar added the enhancement 🚀 New feature or request label Mar 13, 2023
@florentlotthepro
Copy link
Contributor

Hello @SayadiMohamedOmar,
Thanks for your improvement request.

Can you give us more information about how you imagine the naming?
Country flags are a little different because a country code is a worldwide naming convention, there is no naming like that for icons.

Do we agree on something like the name of the icon on Figma with -fill or -line suffix? (Ex: home-fill and home-line)

@SayadiMohamedOmar
Copy link
Author

Hello @florentlotthepro
yes i think it will be great if we use the icon name of Figma like you mentioned 🙏🏾👌🏿

@florentlotthepro
Copy link
Contributor

florentlotthepro commented Mar 22, 2023

Hello @mackoj, What is your opinion on that?

@mackoj
Copy link
Contributor

mackoj commented Mar 22, 2023

I think it's a great idea.

@mackoj
Copy link
Contributor

mackoj commented Mar 22, 2023

I will add it to my ticket for the next major version of vitamin.

@lauthieb lauthieb added help wanted ✋ Extra attention is needed community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community and removed help wanted ✋ Extra attention is needed labels Mar 24, 2023
@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request
Projects
Status: 🔖 Dev to do
Development

No branches or pull requests

4 participants