Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add modal component #11

Open
lauthieb opened this issue Jan 21, 2022 · 2 comments
Open

feat: add modal component #11

lauthieb opened this issue Jan 21, 2022 · 2 comments
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request SwiftUI UIKit

Comments

@lauthieb
Copy link
Member

New component

Add modal component.

Documentation links
@lauthieb lauthieb added the enhancement 🚀 New feature or request label Jan 21, 2022
@daniel-dumortier
Copy link
Contributor

@lauthieb This effect of overlay for modal is the default behavior on iOS UIKit when you present a ViewController (a new "screen").
There is no specific dev to do in Vitamin for that.

@florentlotthepro I do not master enough SwiftUI to know if it is also a standard behaviour, and so, if dev is needed. Can you help on that ?

@florentlotthepro
Copy link
Contributor

It's the same for SwiftUI.

@lauthieb lauthieb added help wanted ✋ Extra attention is needed community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community and removed help wanted ✋ Extra attention is needed labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request SwiftUI UIKit
Projects
Decathlon Design System
Status: 🔖 Dev to do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lauthieb @daniel-dumortier @florentlotthepro