Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: issues on VitaminTextField for UIKit #106

Open
7 tasks
florentlotthepro opened this issue Dec 22, 2022 · 0 comments
Open
7 tasks

bug: issues on VitaminTextField for UIKit #106

florentlotthepro opened this issue Dec 22, 2022 · 0 comments
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community UIKit

Comments

@florentlotthepro
Copy link
Contributor

Describe the bug

After the review of the VitaminTextField on UIKit, we identified some points to fix:

  • The helper text is too close to the bottom of the text field. It should be at 2px (like the counter).
  • The placeholder in dark mode is too visible (content tertiary).
  • When the text field is filled, the text inside should be black (content primary).
  • The label on the filled style should be grey (content tertiary).
  • The text field's border in the active, error, and success states should have a thick of 2px.
  • The text field's border in the disable state is more visible than when no disable > there must be a mistake.
  • The icon for the filled style seems to be too high. It should at 4px of the text field.

Steps to reproduce

You can see it in the showcase.

@florentlotthepro florentlotthepro added bug 🐛 Something isn't working UIKit labels Dec 22, 2022
@florentlotthepro florentlotthepro changed the title bug: bug: issue on VitaminTextField for UIKit Dec 22, 2022
@florentlotthepro florentlotthepro changed the title bug: issue on VitaminTextField for UIKit bug: issues on VitaminTextField for UIKit Dec 22, 2022
@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
@mackoj mackoj added the community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community UIKit
Projects
Status: 🔖 Dev to do
Development

No branches or pull requests

3 participants