Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for incorrect ohlc data fetching during live trade #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for incorrect ohlc data fetching during live trade #35

wants to merge 1 commit into from

Conversation

dimnorin
Copy link

@dimnorin dimnorin commented Dec 1, 2020 •
edited
Loading

Fixes #34

qinwang-ai
qinwang-ai reviewed Aug 30, 2021
View reviewed changes
Copy link
Contributor

@qinwang-ai qinwang-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in comment that in class CCXTFeed(with_metaclass(MetaCCXTFeed, DataBase)):

" Added drop_newest option to avoid loading incomplete candles where exchanges do not support sending ohlcv params to prevent returning partial data"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinwang-ai qinwang-ai qinwang-ai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect ohlc on fetching during live trading
2 participants
@dimnorin @qinwang-ai