Firefox is not sorting correctly when format contains spaces or colons #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give me a link to a page showing the issue please? I don't quite get why Moment wouldn't be parsing a date format that it is given. It sounds like you might be giving it a date which isn't in the format specified? |
|
Not out of the box, the code is used internally. I can see if I can make a clean example somewhere. However, as far as I understand, object properties in javascript can not contain spaces and colons. See https://mothereff.in/js-variables#foo%20bar and https://mothereff.in/js-variables#foo%3Abar. |
|
I'm fairly certain they can - example. |
|
Going to close for now as no test case provided. If you are still having issues with this, please feel free to repopen with a link to a test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When format is something alike
DD-MM-YYYY HH:mmI can't sort correctly. Sorting seems to happens on as if it is a number (01-01 ... 01-02 ... 02-01) instead of as a date.This happens in Firefox. At least Chrome doesn't seem to be affected.