Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #34

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fix CI #34

merged 2 commits into from
Jun 10, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jun 8, 2024

No description provided.

@AllanJard AllanJard merged commit fddfa2f into DataTables:master Jun 10, 2024
15 checks passed
@mvorisek mvorisek deleted the fix_ci branch June 10, 2024 10:25
@mvorisek
Copy link
Contributor Author

@AllanJard in the PHP Editor download/release (https://editor.datatables.net/download/download?type=php) there is a controllers directory - I would like to apply PHP CS Fixer on it + propose some changes as when we upgrade, I always get a huge diff when saving the files into our internal VCS.

Is there a GitHub repo for it and would you mind inviting me into it?

@AllanJard
Copy link
Contributor

Its a private bitbucket repo for the Editor examples. I'm somewhat surprised that you are committing the demo controllers to be honest since they are only relevant to the Editor examples, but yes, that is something that I will look at getting sorted out. Thanks for flagging it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants