From e255da591fd0eb12737fcb095850e0b606e7fb75 Mon Sep 17 00:00:00 2001 From: Ian Rice <31070352+ianrice07@users.noreply.github.com> Date: Wed, 3 Apr 2024 14:07:40 -0400 Subject: [PATCH 1/2] Updated Layout type to allow null value Current implementation only allows value or undefined. In order to remove the default layout a null value must be used, which isn't evaluated as part of undefined. --- types/types.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/types.d.ts b/types/types.d.ts index 6b263c7..60fec64 100644 --- a/types/types.d.ts +++ b/types/types.d.ts @@ -182,7 +182,7 @@ type LayoutEdge = 'Start' | 'End'; type LayoutKeys = `${LayoutSide}${LayoutNumber}${LayoutEdge}` | `${LayoutSide}${LayoutNumber}`; -type Layout = Partial | Feature[]>>; +type Layout = Partial | Feature[] | null>>; /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * From 3fb18306e242d82f789bce572e6c14138dc64820 Mon Sep 17 00:00:00 2001 From: Ian Rice <31070352+ianrice07@users.noreply.github.com> Date: Wed, 3 Apr 2024 14:49:15 -0400 Subject: [PATCH 2/2] Update SearchInputColumn type Column index value was in the row index position for the function. Added rowIndex as third param, changed column to columnIndex and shifted it to fourth param --- types/types.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/types.d.ts b/types/types.d.ts index 60fec64..55225e4 100644 --- a/types/types.d.ts +++ b/types/types.d.ts @@ -68,7 +68,7 @@ export type CellIdxWithVisible = { } export type SearchInput = string | RegExp | ((data: string, rowData: T) => boolean); -export type SearchInputColumn = string | RegExp | ((data: string, rowData: T, column: number) => boolean); +export type SearchInputColumn = string | RegExp | ((data: string, rowData: T, rowIndex: number, columnIndex: number) => boolean); export type HeaderStructure = { cell: HTMLElement;