Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rgb to RGB in css #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fareesh
Copy link

@fareesh fareesh commented Apr 1, 2024

Solves some older SASS compilation issues where the new css rgb function conflicts with the SASS function of the same name

Solves some older SASS compilation issues where the new css rgb function conflicts with the SASS function of the same name
@AllanJard
Copy link
Contributor

Thanks for the PR. I don't think I've encountered a conflict with this before. What version of SASS is causing the issue?

@fareesh
Copy link
Author

fareesh commented Apr 4, 2024

I'm seeing an error with sass 1.68.0

Relevant StackOverflow post: https://stackoverflow.com/questions/71805735/error-function-rgb-is-missing-argument-green-in-sass

@AllanJard
Copy link
Contributor

Sorry for the long delay in replying here. If you use a more up to date version of the sass package, does it then work? I've got DataTables being built with 1.75.0 at the moment and 1.77.4 appears to be the current release (at the time of writing).

One thing with this fix, is that the output in this repo is actually generated by SASS! The DataTables sorce repo gets compiled by SASS, and then committed to this repo (and others). So the change wouldn't be as simple as updating this repo unfortunately.

I'm inclinded to say that if it works with newer SASS packages, then we'll leave it like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants