Add aria-label to page length select for accessibility #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an aria-label attribute to the length select menu. I tried to follow the pattern I had seen on the sort element aria code using oAria settings.
I ended up running the make file build scripts and during that I found that create_function was removed from the newest major version of PHP. I have switched over to an anonymous function. It didn't seem to cause any issues on my end but if you'd prefer that I remove that part from this PR I would be more than happy to do so.
I also noticed that the build script would always print out that you were building master even if that wasn't true, so I tweaked it to show the current branch so it's not confusing. Once again, I can remove that if you prefer.
I have built and copied the output into a working site on one of my active internal projects and it worked great with no defects that I have noticed.
Please let me know if there's anything you'd like me to tweak.
This is a very minor change so I'm hoping it can go out before version 2.0 if you decide to publish another version.