Build failing due to JSHint errors

[advaitju]

I pulled the latest code and attempted to build it without changes. However, the build is failing due to JSHint errors.

Reproduce setup:
I'm running on Windows WSL (Ubuntu 18.01)

cd ~
git clone [email protected]:DataTables/DataTablesSrc.git
sudo apt install ruby-sass     # Add missing sass
mkdir ~/jshintfix/
cd ~/jshitfix/
npm init -y
npm i [email protected]
sudo ln -s $PWD/node_modules/jshint/bin/jshint /usr/bin/    # Connect JSHint binary
cd ~/DataTablesSrc.git
npm run build

JSHint errors:

/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1331, col 9, '_ext' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1332, col 9, '_Api' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1514, col 9, '_stripHtml' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1708, col 14, '_fnCamelToHungarian' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1747, col 14, '_fnLanguageCompat' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1809, col 14, '_fnCompatOpts' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1850, col 14, '_fnCompatCols' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1870, col 14, '_fnBrowserDetect' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 1984, col 14, '_fnAddColumn' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2016, col 14, '_fnColumnOptions' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2235, col 14, '_fnGetColumns' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2325, col 14, '_fnApplyColumnDefs' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2405, col 14, '_fnAddData' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2455, col 14, '_fnAddTr' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2507, col 14, '_fnGetCellData' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2592, col 14, '_fnGetObjectDataFn' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2717, col 14, '_fnSetObjectDataFn' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 2980, col 14, '_fnGetRowElements' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 3089, col 14, '_fnCreateTr' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 3174, col 14, '_fnRowAttributes' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 3733, col 14, '_fnDetectHeader' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 3808, col 14, '_fnGetUniqueThs' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 3978, col 14, '_fnAjaxUpdate' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4009, col 14, '_fnAjaxParameters' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4117, col 14, '_fnAjaxUpdateDraw' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4167, col 14, '_fnAjaxDataSrc' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4190, col 14, '_fnFeatureHtmlFilter' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4286, col 14, '_fnFilterComplete' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4339, col 14, '_fnFilterCustom' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4376, col 14, '_fnFilterColumn' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4409, col 14, '_fnFilter' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4465, col 14, '_fnFilterCreateSearch' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4501, col 9, '_fnEscapeRegex' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4507, col 14, '_fnFilterData' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4615, col 14, '_fnFeatureHtmlInfo' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4649, col 14, '_fnUpdateInfo' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4687, col 14, '_fnInfoMacros' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4714, col 14, '_fnInitialise' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4798, col 14, '_fnInitComplete' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4831, col 14, '_fnFeatureHtmlLength' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 4897, col 14, '_fnFeatureHtmlPaginate' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5031, col 14, '_fnFeatureHtmlProcessing' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5048, col 14, '_fnProcessingDisplay' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5063, col 14, '_fnFeatureHtmlTable' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5221, col 14, '_fnScrollDraw' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5504, col 14, '_fnApplyToChildren' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5543, col 14, '_fnCalculateColumnWidths' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5771, col 9, '_fnThrottle' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5781, col 14, '_fnConvertToWidth' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5805, col 14, '_fnGetWidestNode' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5826, col 14, '_fnGetMaxLenString' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5851, col 14, '_fnStringToCss' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5871, col 14, '_fnSortFlatten' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 5943, col 14, '_fnSort' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6069, col 14, '_fnSortAria' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6208, col 14, '_fnSortAttachListener' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6246, col 14, '_fnSortingClasses' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6279, col 14, '_fnSortData' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6322, col 14, '_fnSaveState' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6358, col 14, '_fnLoadState' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6460, col 14, '_fnSettingsFromNode' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6479, col 14, '_fnLog' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6522, col 14, '_fnMap' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6564, col 14, '_fnExtend' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6600, col 14, '_fnBindAction' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6629, col 14, '_fnCallbackReg' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6655, col 14, '_fnCallbackFire' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6677, col 14, '_fnLengthOverflow' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6702, col 14, '_fnRenderer' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 6731, col 14, '_fnDataSource' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 7824, col 9, '_selector_row_indexes' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 7864, col 27, 'i' is already defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 7864, col 32, 'ien' is already defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 8312, col 9, '__details_events' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 14814, col 14, '_addNumericSort' was used before it was defined.
/mnt/c/Users/ajunnarkar/dev/DataTablesSrc/build/../built/js/jquery.dataTables.js: line 15069, col 14, '_fnExternApiFunc' was used before it was defined.

[DataTables]

Interesting - thanks for letting me know about that. It should actually run correctly without passing JSHint (since all the unit tests are currently passing), but we will look into why that is happening with a clean checkout.