Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization][Data Development] variable suggestion optimization #3982

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

MactavishCui
Copy link
Contributor

Purpose of the pull request

https://github.com/DataLinkDC/dinky/issues/3977

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:
Before:
83615141c4801c05df5dc6cc5911e28
23c01d98b491d3ed133875e2eee1607

After:
1d019e2bffb735b8b6ff527cc80739d
95c4471b2a51984c11288a653707f80

Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo added the Optimization Optimization function label Nov 28, 2024
@aiwenmo aiwenmo added this to the 1.2.0 milestone Nov 28, 2024
@aiwenmo aiwenmo linked an issue Nov 28, 2024 that may be closed by this pull request
3 tasks
@aiwenmo aiwenmo merged commit 0ee8278 into DataLinkDC:dev Nov 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Optimization][Data Development] Code auto completion on fragment
2 participants