[Feature-3893][core][admin][web] Flink SQL task Support insert result preview #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
MactavishCui
changed the title
3 tasks
3 tasks
Zzm0809
requested changes
Nov 9, 2024
dinky-core/src/main/java/org/dinky/explainer/mock/MockStatementExplainer.java
Outdated
Show resolved
Hide resolved
|
你能针对此扩展功能补充一下该文档吗? |
Zzm0809
requested changes
Nov 10, 2024
dinky-core/src/main/java/org/dinky/explainer/mock/MockStatementExplainer.java
Outdated
Show resolved
Hide resolved
…ng catalog and table scheme changed
Sure！我将于近两天更新docs部分，补充当前拓展功能的效果、达成的前提等信息。 |
非常感谢您的贡献, 文档可以后续补充, 单独 pr 以下, 本次新功能 pr 将被合并 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request is aimed at implementing the feature of insert result preview.
Brief change log
A customized connector class is added to write insert result into accumulator.
A mock statement explainer is added to convert insert statement into mock.
Some related changes of model core and admin.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
