[Refactor][Web]Refactoring a new data development interface to enhance the user experience #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zzm0809
reviewed
Oct 21, 2024
| if (currentState.type === 'local') { | ||
| return ['local'] | ||
| } | ||
| if (currentState.type === 'standalone' || currentState.type === 'kubernetes-session' || currentState.type === 'yarn-session') { |
Zzm0809
reviewed
Oct 21, 2024
| layout='horizontal' | ||
| variant={"filled"} | ||
| // disabled={currentState?.step === JOB_LIFE_CYCLE.PUBLISH || isLockTask} // 当该任务处于发布状态时 表单禁用 不允许修改 | when this job is publishing, the form is disabled , and it is not allowed to modify | ||
| disabled={currentState?.step === JOB_LIFE_CYCLE.PUBLISH} // 当该任务处于发布状态时 表单禁用 不允许修改 | when this job is publishing, the form is disabled , and it is not allowed to modify |
There was a problem hiding this comment.
作业责任人机制锁需要 todo 一下
由 @18216499322 协助完成
Zzm0809
reviewed
Oct 21, 2024
| versionId: row.versionId | ||
| }; | ||
| await handleOption( | ||
| 'api/task/rollbackTask', |
Signed-off-by: Zzm0809 <[email protected]>
Signed-off-by: Zzm0809 <[email protected]>
Signed-off-by: Zzm0809 <[email protected]>
…ckyoungh/new_dataStudio
Signed-off-by: Zzm0809 <[email protected]>
…ckyoungh/new_dataStudio
Signed-off-by: Zzm0809 <[email protected]>
…ckyoungh/new_dataStudio # Conflicts: # dinky-web/src/pages/DataStudioNew/CenterTabContent/SqlTask.tsx
Signed-off-by: Zzm0809 <[email protected]>
3 tasks
chenhaipeng
pushed a commit
to chenhaipeng/dinky
that referenced
this pull request
Nov 12, 2024
…e the user experience (DataLinkDC#3854) Signed-off-by: Zzm0809 <[email protected]> Co-authored-by: zackyoungh <[email protected]> Co-authored-by: Zzm0809 <[email protected]> Co-authored-by: gaoyan <[email protected]> Co-authored-by: gaoyan1998 <[email protected]> Co-authored-by: zhangyuhang <[email protected]> Co-authored-by: LUOSHANGJIE\71826 <[email protected]> Co-authored-by: 18216499322 <[email protected]> Co-authored-by: Zzm0809 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: