Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization][Job Name] Job name support underline characters - to compatible with version 0.7 #3823

Closed
3 tasks done
zhuxt2015 opened this issue Sep 21, 2024 · 2 comments · Fixed by #3864
Closed
3 tasks done
Labels
Optimization Optimization function

Comments

@zhuxt2015
Copy link
Contributor

zhuxt2015 commented Sep 21, 2024

Search before asking

  • I had searched in the issues and found no similar optimization requirement.

Description

建议job名字支持下划线,这样能够兼容0.7版本的job名字。k8s中的pod名字可以替换job名字中的下划线为短横线
It is recommended that the job name be underline, so that it can be compatible with the 0.7 version of the job name. The pod name in k8s can be replaced underline with an dash in the job name.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zhuxt2015 zhuxt2015 added Optimization Optimization function Waiting for reply Waiting for reply labels Sep 21, 2024
@gaoyan1998
Copy link
Contributor

Good idea,Are you willing to be fix this issue?

@Zzm0809
Copy link
Contributor

Zzm0809 commented Sep 23, 2024

Can you contribute to this optimization?
If you plan to contribute to this optimization, because k8s tasks cannot support underscores, you need to add a tooltips to prompt the user when creating tasks. In all k8s modes, underscores will be replaced to avoid inconsistent task names resulting in a series of FAQs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants